Old 05-06-2006, 09:10 PM   #1
neoxed
Too much time...
FlashFXP Beta Tester
ioFTPD Scripter
 
Join Date: May 2003
Posts: 1,326
Default nxTools v1.0.4

Changes:
  • NEW: Check if the request was already filled before adding it.
  • NEW: Extensions are now loaded using Tcl's package system.
  • FIX: Properly quote string values in SQL statements.
  • FIX: The "SITE PRE STATS" command was broken in v1.0.3.
  • FIX: The maximum request age should be logged in seconds.
  • FIX: The release check for "SITE REQUEST" did not allow some valid names.
Notes:
  • Update ASAP, this fixes a possible SQL injection exploit.
  • The procedure I used for escaping strings in SQL statements was left over from the MySQL days of nxTools. When I migrated to SQLite I never modified the procedure, so strings were not properly escaped.
Download:

http://www.inicom.net/pages/en.ioftpd-scripts.php?id=78
neoxed is offline   Reply With Quote
Old 05-07-2006, 04:32 AM   #2
Freestyler
Junior Member
ioFTPD Registered User
 
Join Date: Nov 2003
Posts: 19
Default

I upgraded from 1.0.3 to 1.0.4 and did what it says in upgrading.txt. Uploading is broke now.
It can be fixed to change 'result' to '$result' in nxDupe.tcl.

Code:
--------------------------- ErrorInfo ----------------------------
syntax error in expression "!result && [IsTrue $dupe(CheckFiles)]": variable references require preceding $
    ("if" test expression)
    while compiling
"if {!result && [IsTrue $dupe(CheckFiles)]} {
                set result [CheckFiles $virtualPath]
            }"
    ("PRESTOR" arm line 6)
    invoked from within
"switch -- $event {
        DUPELOG {
            set virtu
Freestyler is offline   Reply With Quote
Old 05-07-2006, 02:28 PM   #3
neoxed
Too much time...
FlashFXP Beta Tester
ioFTPD Scripter
 
Join Date: May 2003
Posts: 1,326
Default

Damnit, can't believe I missed that.

Thanks for pointing out that typo, it's been fixed in v1.0.4a (I reposted the file).
neoxed is offline   Reply With Quote
Old 05-28-2006, 07:20 AM   #4
zOrP
Senior Member
 
Join Date: Jan 2005
Posts: 282
Default

one small question..

the site rebuild part..

i get

(14:08:38) [1] site rebuild
(14:08:38) [1] 200-.-[DupeUpdate]-----------------------------------------------------------.

then it makes 2 files
DupeDirs.db-journal
DupeFiles.db-journal

thats all.. it doesnt update the dupedb's..

sometimes i also get this

(14:15:20) [1] site rebuild
(14:15:20) [1] 200-.-[DupeUpdate]-----------------------------------------------------------.
(14:15:20) [1] 200-| Updating dupe database from: J:/APPS |
(14:15:20) [1] 200 Command successful.

only the first section..
but its not updated.. :x
takes 2 mins.. then site chrash.

worked yesterday, but i decided to remove requests from rebuild.
so i deleted the db's, created new and voila.. :x

solution?
:>

this is from systemerror.log

05-28-2006 14:52:34 "..\scripts\nxTools\nxDupe.tcl" terminated abnormally
--------------------------- ErrorInfo ----------------------------
database is locked
while executing
"DirDb eval {BEGIN; DELETE FROM DupeDirs;}"
(procedure "RebuildDb" line 16)
invoked from within
"RebuildDb"
("REBUILD" arm line 2)
invoked from within
"switch -- $event {
DUPELOG {
set virtualPath [GetPath $pwd [join [lrange $argList 2 end]]]
if {[IsTrue $dupe(CheckDirs..."
(procedure

EDIT:
i forgot a close bracket in nxtools.cfg..

and patience is a virtue.. :>
zOrP is offline   Reply With Quote
Old 05-28-2006, 10:33 AM   #5
zOrP
Senior Member
 
Join Date: Jan 2005
Posts: 282
Default

would be nice with a site msg function in next version..

for filled and wiped reqs.. :>
zOrP is offline   Reply With Quote
Old 05-28-2006, 01:37 PM   #6
neoxed
Too much time...
FlashFXP Beta Tester
ioFTPD Scripter
 
Join Date: May 2003
Posts: 1,326
Default

No, I won't add a message-board function to my script, it's completely unnecessary. If you really need one, there are plenty of existing message-board scripts.
neoxed is offline   Reply With Quote
Old 05-28-2006, 02:50 PM   #7
zOrP
Senior Member
 
Join Date: Jan 2005
Posts: 282
Default

true.. its not really needed.

Only for filled reqs..

thnx anyway
zOrP is offline   Reply With Quote
Reply

Tags
download, fix, request, sql, strings

Thread Tools
Display Modes Rate This Thread
Rate This Thread:

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is Off
HTML code is Off

Forum Jump


All times are GMT -5. The time now is 05:03 PM.

Parts of this site powered by vBulletin Mods & Addons from DragonByte Technologies Ltd. (Details)