ioFTPD v7.7.3 (STABLE) Released - Page 3

Yil · 05-07-2011, 05:04 PM

Oh, I should mention that the OnlineData_Extra_Fields is a potential issue with old .exe based scripts which is why it's an option but it appears to work ok with sitewho and ioGUI in shared memory mode. However I don't think zipscripts normally use the client data field, but if they do you might need to disable the feature.

On the other hand, keep_links_in_paths is sort of ignored and the full real path used because old .exe zipscripts don't understand symlinks in paths very well since they never had to deal with them. The big issue here is the full real path wasn't always correct if the keep_links_in_paths feature was disabled because of bugs. Was fixed in various ways in v7.6.3 and v7.5.7. My guess is disabling the feature in the older versions exposed the problems I fixed and that was causing your issues, but I don't see any reason why disabling it now would be causing problems.

Zer0Racer · 05-08-2011, 06:35 AM

Quote:

Originally Posted by Yil

Zer0Racer: error number 87 is ERROR_INVALID_PARAMETER and based on a quick search seems to indicate that either the command line is too long (32k - unlikely!) or the environmental variables are too long (32k). If you do 'set' from a command prompt it should show you the currently defined variables. ioFTPD then adds to that whatever is in etc/ioftpd.env after expanding all the cookies...

If you have say 25-30k worth of normally defined variables perhaps when ioFTPD adds it's own with longer named directories you are getting errors but with shorter you are fine. My guess is you've installed more software that automatically added some environmental variables or appended its path to the PATH variable and now you are hitting the 32k total limit...

You can modify the list of windows environmental variables via system properties -> advanced system settings -> environmental variables or something like that depending on which version of windows you are running.

Yeah I searched for it too and shortened it so now I only have

Code:

Path=C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem

But that didn't help.

Edit: Same zipscript executable still works with 7.3.3 without the CreateProcess failure. When I try it in 7.7.1 it doesn't work. Same machine.

Yil · 05-08-2011, 07:02 PM

Did you see what 'set' from a command prompt shows? I know some things like java, tcl, etc can end up having really long environmental variables for include, class, etc paths... 32k is big, so it should be obvious if that's the issue. Other than that we could try running cmd.exe directly and make it print the output of 'set' to a file and then see what the actual args getting to the child process are just in case it's an ioFTPD cookie issue.

There's also the args.exe script that pops up a window with the args to the program so you can see what the command line looked like. Unlikely, but not that hard to check.

Can you see if the paths you are having issues with have anything in common. In particular do they have symbolic links in the path, really long names, etc.

Zer0Racer · 05-09-2011, 05:35 AM

You mean something like this?

Code:

OnUploadComplete =  EXEC c:\windows\system32\cmd.exe /c set > c:\temp\set.txt

Just leaves me with an empty file in 7.3.3 and 7.7.1.

The zipscript works in 7.3.3 but not in 7.7.1. What differences are there between those two versions of ioFTPD?

Yil · 05-09-2011, 11:53 AM

Well, you probably don't want to use an event because it appends arguments to the command line... Just define a new EXEC site command.

However, I decided to test it locally to make sure that would work and it sorta did, but I think I might have an idea of what the problem might be. One of the v7.7.0 changes indicates that I fixed a problem with handling extra blank lines being generated when processing message files. However, the ioftpd.env file is processed as a message file so you can use cookies in it, and it's likely I broke something. Checking that now.

Zer0Racer · 05-09-2011, 12:24 PM

Code:

EXEC c:\windows\system32\cmd.exe /c set > c:\temp\set733.txt

In v7.3.3 it seems to print the ioftpd.env correctly. See: http://pastebin.com/K7ZNX2GL

In v7.7.1 I get this, and this only:

Code:

ACCSPEED=403.1115

COMSPEC=c:\windows\SysWOW64\cmd.exe
PATHEXT=.COM;.EXE;.BAT;.CMD;.VBS;.JS;.WS;.MSC
PROMPT=$P$G

Yil · 05-09-2011, 12:57 PM

I found the problem. Processing the cookies in ioftpd.env is weird because each "line" is terminated with \0 instead of \r\n, plus there is an extra \0 at the very end. My "fix" assumed a normal C-style \0 terminated string and thus couldn't handle this weird environmental output style. Undoing the v7.7.0 change and things worked over here as well, but I'll need to figure out another solution.

Testing for a new solution exposed another issue however, and I really should fix that as well so not sure if a new version will be out today.

Yil · 05-09-2011, 04:21 PM

Code:

v7.7.2 Release Notes:

1) Files in \System:
   Changed : ioFTPD.[exe,pdb] - Version 7.7.2.0


*** Bug Fixes

2) Fixed a bug introduced in v7.7.0 in the message cookie preprocessor that
   treated \0 terminated strings as the end of the input.  That holds true for
   all message cookie files, but was not true when processing the ioftpd.env
   file into individually \0 terminated strings suitable for passing to child
   processes.

3) Fixed a bug introduced in v7.4.0 when all the input/output functions were
   modified to use the new transfer engine with OpenSSL support.  A variable
   was not reset which resulted in mangled commands if the command that was
   sent by the client didn't contain a return character.  Since FTP clients
   send a single command with a return on the end this wasn't noticed until
   I manually connected a raw TCP stream to test the previous fix.

Yil · 05-09-2011, 04:23 PM

Zer0Racer: See if 7.7.2 fixes your problem. Thanks for bring this up since this could break all EXEC scripts.

Zer0Racer · 05-09-2011, 11:56 PM

Yil, you fixed it! Cool. Thanks!

opcode · 05-18-2011, 06:55 AM

From the 7.7.0 release notes:

Code:

 
    [Threads]     : Io_Threads              = 4
                     Remove Encryption_Threads option.
                     Section commands changed.

What does "Section commands changed" mean, e.g. what am i supposed to change in my ioftpd.ini when upgrading from 7.6.3 ?

ArtX · 05-18-2011, 12:06 PM

Quote:

Originally Posted by opcode

From the 7.7.0 release notes:

Code:

 
    [Threads]     : Io_Threads              = 4
                     Remove Encryption_Threads option.
                     Section commands changed.

What does "Section commands changed" mean, e.g. what am i supposed to change in my ioftpd.ini when upgrading from 7.6.3 ?

All this

Code:

v7.7.0 Release Notes:

1) Files in \System:
   Changed : ioFTPD.[exe,pdb] - Version 7.7.0.0
   Changed : tcl85t.[dll,pdb] - Version 8.5.2.9
   Changed : libeay32.dll, ssleay32.dll - Version 1.0.0.4
     Added : libeay32.pdb, ssleay32.pdb - Version 1.0.0.4
   Changed : Help-SiteCmds.ini
   Changed : ioFTPD.ini - summary of changes by section...
     [FTP_Service] : OpenSSL_Options options and comments changed.
     [VFS]         : Default_Directory_Attributes    = 777 0:0
     [FTP_SITE_Permissions] : Rename "sectionnum" to "sectionums"
                              stat              =     *
     [Ftp]         : Single_Closed_Exempt_Name added
                     Who_Sort_Output added
                     Who_Hidden_Users comment changed
                     Banned_User_Flag added
                     Quiet_Login_Flag
     [Threads]     : Io_Threads              = 4
                     Remove Encryption_Threads option.
                     Section commands changed.

2) Directories in \lib:
     Replace entire reg1.2 directory.
     Replace entire dde1.3 directory.
     Replace entire tcl8 directory.
     The tcl8.5 directory is a bit trickier.  Probably the easiest thing to
       do is copy and overwrite all the files from the new directory into your
       existing dir.  For the record, here's some info on the subdirs:
         TCL: http1.0, msgs, opt0.4, tzdata (encoding not shipped w/ioFTPD)
         ioNinja-v0.8.9.6-2009-06-29: encoding, http, http2.5, twapi, zlib1.1
           *** nxHelper shipped with ioNinja is v2.3 but you need the v2.4
               one from nxTools else you get package require errors!
           *** opt0.4 is part of TCL, use the one shipped with ioFTPD
           *** reg1.1 is old, ioFTPD includes lib/reg1.2 which is better
     lib/nxHelper and lib/sqlite3 are part of nxTools

3) Files in \text\ftp:
   Changed : GroupList.[Header, Body]
   Changed : MyInfo.[Sections, Totals]
   Changed : UserInfo.[Sections, Totals]
   Changed : UserList.Footer

4) Files in \Doc:
   Changed : Cookies.txt
   Changed : Events.txt
   Changed : iTCL.txt
   Changed : Site-cmds.txt

5) Files in \Source
   Changed : Site-cmds.help

Replace all the files it tells you to replace, then look at new ioftpd.ini and look at your old one and make the changes it suggests

For example, look under

[Threads]

in ioftpd.ini and change (if required)

Io_Threads = 4

then lok for the

Encryption_Threads - line and remove it

As for the section commands changed, im guessing that

Changed : ioFTPD.ini - summary of changes by section...

Is all you have to worry about as it lists what has been changed there.

After you have done all that follow the ChangeLog.txt for 7.7.2, and you should be good to go

opcode · 05-18-2011, 01:03 PM

yes, i replaced all the files etc etc and changed the .ini accordingly to the changelog. i am just not sure what a "section command" is supposed to be and wether "section commands changed" means that i have to edit some specific part in the ioftpd.ini besides the stuff that got mentioned above.

Yil · 05-18-2011, 04:07 PM

Oops, that should read "section comments" not "section commands". I just changed the comments (the # lines) for the section to remove references to the encryption threads, etc. Nothing functional changed, just the comments.

Yil · 05-29-2011, 02:28 PM

I'm looking for some uptime/crash feedback. On a reasonably busy v7.7.1 server (no exec scripts so 7.7.2 wasn't necessary) I've seen 30 days. 7.7.2 hasn't been out that long, but I'm really interested in any crashlogs anyone might have of 7.7.2. I'm hoping nobody has any and it's finally relatively stable...

Let me know what you're seeing.

"Site uptime" will give you OS and FTP uptime in case the server auto-rebooted to patch and stuff. These should be pretty close, but not exact if the server requires drive mounting, etc be done manually they can differ by half a day or so I'd guess.