Go Back   FlashFXP Forums > > > >

Bug Reports Report bugs here. (non-beta releases only)

 
 
Thread Tools Display Modes
Old 12-22-2002, 08:31 AM   #1
darkone
Disabled
FlashFXP Registered User
ioFTPD Administrator
 
darkone's Avatar
 
Join Date: Dec 2001
Posts: 2,230
Default Some minor bugs

Just downloaded 2.0 to test compatability with my daemon. Noticed couple of minor 'bugs' in it:

- It does not perform SSL_shutdown() when requested (Most clients and servers are violating this TLS rule, but it's the only way to check data integrity)
- Instead of ABOR some garbage is being sent to daemon

Quote:
www.openssl.org
The shutdown procedure consists of 2 steps: the sending of the ``close notify'' shutdown alert and the reception of the peer's ``close notify'' shutdown alert. According to the TLS standard, it is acceptable for an application to only send its shutdown alert and then close the underlying connection without waiting for the peer's response (this way resources can be saved, as the process can already terminate or serve another connection). When the underlying connection shall be used for more communications, the complete shutdown procedure (bidirectional ``close notify'' alerts) must be performed, so that the peers stay synchronized.
Cheers, dark0n3
darkone is offline  
Old 12-22-2002, 09:05 AM   #2
bigstar
FlashFXP Developer
FlashFXP Administrator
ioFTPD Beta Tester
 
bigstar's Avatar
 
Join Date: Oct 2001
Posts: 8,012
Default

SSL_shutdown is issued prior to closing the socket.
bigstar is offline  
Old 12-22-2002, 10:37 AM   #3
darkone
Disabled
FlashFXP Registered User
ioFTPD Administrator
 
darkone's Avatar
 
Join Date: Dec 2001
Posts: 2,230
Default

Odd.. I'll investigate it further then
darkone is offline  
Old 12-22-2002, 10:53 AM   #4
darkone
Disabled
FlashFXP Registered User
ioFTPD Administrator
 
darkone's Avatar
 
Join Date: Dec 2001
Posts: 2,230
Default

SSL_shutdown() on server end returns 0:

The shutdown is not yet finished. Call SSL_shutdown() for a second time, if a bidirectional shutdown shall be performed. The output of SSL_get_error(3) may be misleading, as an erroneous SSL_ERROR_SYSCALL may be flagged even though no error occurred.

You are performing bidirectional shutdown?
darkone is offline  
Old 12-22-2002, 11:00 AM   #5
darkone
Disabled
FlashFXP Registered User
ioFTPD Administrator
 
darkone's Avatar
 
Join Date: Dec 2001
Posts: 2,230
Default

Further note: With SmartFTP I get 0 on first call, and shutdown completes on second call. Maybe you're missing the second call to SSL_shutdown?
darkone is offline  
Old 12-22-2002, 09:53 PM   #6
bigstar
FlashFXP Developer
FlashFXP Administrator
ioFTPD Beta Tester
 
bigstar's Avatar
 
Join Date: Oct 2001
Posts: 8,012
Default

Ah twice? I was not aware that it needed to be called twice. I'll add that, thanks!

To be honest those ssl docs read like a foreign language, it's nearly impossible for me to make heads or tails out of it.
bigstar is offline  
Old 12-29-2002, 10:27 AM   #7
darkone
Disabled
FlashFXP Registered User
ioFTPD Administrator
 
darkone's Avatar
 
Join Date: Dec 2001
Posts: 2,230
Default

Why does directory named 'share' get highlighted? (highlight & skiplists are empty)
darkone is offline  
Old 12-29-2002, 04:35 PM   #8
bigstar
FlashFXP Developer
FlashFXP Administrator
ioFTPD Beta Tester
 
bigstar's Avatar
 
Join Date: Oct 2001
Posts: 8,012
Default

Hmm, I don't know. 'Share' Is not highlighted for me.
bigstar is offline  
Old 12-30-2002, 03:01 PM   #9
darkone
Disabled
FlashFXP Registered User
ioFTPD Administrator
 
darkone's Avatar
 
Join Date: Dec 2001
Posts: 2,230
Default

odd.. it isn't highlighted anymore, maybe i was just too tired
darkone is offline  
Old 01-26-2003, 06:20 PM   #10
bigstar
FlashFXP Developer
FlashFXP Administrator
ioFTPD Beta Tester
 
bigstar's Avatar
 
Join Date: Oct 2001
Posts: 8,012
Default

I was re-reading the docs and it says you should call SSL_shutdown again if the return value is 0..

When this code was changed it always called SSL_shutdown twice.. I think i'll change this so SSL_shutdown is only called again if the result is 0.
bigstar is offline  
 

Tags
alert, notify, peers, shutdown

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -5. The time now is 01:08 AM.

Parts of this site powered by vBulletin Mods & Addons from DragonByte Technologies Ltd. (Details)