Go Back   FlashFXP Forums > > >

Bug Reports Report bugs here.

 
 
Thread Tools Display Modes
Old 12-03-2004, 04:13 AM   #1
Witchbender
Junior Member
FlashFXP Registered User
 
Join Date: Mar 2002
Posts: 10
Default Compare Folders with advanced options

Not sure if it is a bug or if i missed something:

when i check the option to "compare name & size" flash shows all ASCII-mode files like sfv and nfo as different though filesize and name is the same. When i do not check that option those files don´t show up upon compare.

Beside of that it would be nice to have an aditional option for not displaying skiplisted files upon compare
Witchbender is offline  
Old 12-03-2004, 04:16 AM   #2
MidKnight
Senior Member
FlashFXP Beta Tester
ioFTPD Registered User
 
Join Date: Oct 2001
Posts: 857
Default

ASCII are generally not the same size, if you change your "display file size as" you'll see there not the same size
MidKnight is offline  
Old 12-03-2004, 05:21 AM   #3
Witchbender
Junior Member
FlashFXP Registered User
 
Join Date: Mar 2002
Posts: 10
Default

thanks for clearing that up ... you are right

hmm... then maybe a 2nd additional advanced option "Ignore size on Ascii mode files"
Witchbender is offline  
Old 12-03-2004, 05:25 AM   #4
MidKnight
Senior Member
FlashFXP Beta Tester
ioFTPD Registered User
 
Join Date: Oct 2001
Posts: 857
Default

Quote:
Originally posted by Witchbender
thanks for clearing that up ... you are right

hmm... then maybe a 2nd additional advanced option "Ignore size on Ascii mode files"
i like that too actually
MidKnight is offline  
Old 12-03-2004, 08:34 AM   #5
chotaire
Member
FlashFXP Scripter
 
Join Date: Sep 2004
Posts: 82
Default

Yup, I second that.
chotaire is offline  
Old 12-03-2004, 10:47 AM   #6
bigstar
FlashFXP Developer
FlashFXP Administrator
ioFTPD Beta Tester
 
bigstar's Avatar
 
Join Date: Oct 2001
Posts: 8,012
Default

An option like this could be added however this adds an extra step in the compare routine, Checking a file against the ascii list is a O(n) operation where n is the number of ascii patterns. This could decrease the speed performance by a good 20% or more.

Let me know if you still think you would use this option and I'll put it on my todo list.
bigstar is offline  
Old 12-03-2004, 10:57 AM   #7
Witchbender
Junior Member
FlashFXP Registered User
 
Join Date: Mar 2002
Posts: 10
Default

after all it will be still faster than manually unselecting the ascii files after compare... so i would really appreciate that beeing in an upcoming version
Witchbender is offline  
Old 12-03-2004, 01:51 PM   #8
bigstar
FlashFXP Developer
FlashFXP Administrator
ioFTPD Beta Tester
 
bigstar's Avatar
 
Join Date: Oct 2001
Posts: 8,012
Default

I just thought of something, What if the files are ASCII type and their size is equal?
bigstar is offline  
Old 12-03-2004, 04:12 PM   #9
MxxCon
Super Duper
FlashFXP Beta Tester
 
Join Date: Oct 2001
Location: Brooklyn, NY
Posts: 3,839
Default

wouldn't that still means that files are possibly of different size? since different OS store text files differently?
__________________
[Sig removed by Administrator: Signature can not exceed 20GB]
MxxCon is offline  
Old 12-03-2004, 04:30 PM   #10
bigstar
FlashFXP Developer
FlashFXP Administrator
ioFTPD Beta Tester
 
bigstar's Avatar
 
Join Date: Oct 2001
Posts: 8,012
Default

Yup, that's why I was thinking it shouldn't match even if the size was equal.
bigstar is offline  
Old 12-03-2004, 04:51 PM   #11
Witchbender
Junior Member
FlashFXP Registered User
 
Join Date: Mar 2002
Posts: 10
Default

Doesn´t that mean that ascii files should be excluded from comparison anyway when using the "compare filesize" option ?
Witchbender is offline  
Old 12-03-2004, 05:11 PM   #12
bigstar
FlashFXP Developer
FlashFXP Administrator
ioFTPD Beta Tester
 
bigstar's Avatar
 
Join Date: Oct 2001
Posts: 8,012
Default

It depends entirely on the ftp server OS, if your transferring between unix and unix or windows and windows then the files will be identical. But if you transfer an ascii file from unix to windows the size will not match.
bigstar is offline  
Old 12-03-2004, 06:47 PM   #13
chotaire
Member
FlashFXP Scripter
 
Join Date: Sep 2004
Posts: 82
Default

I rather live with 20% speed loss than with bugs. Go ahead bigstar.
chotaire is offline  
Old 12-03-2004, 07:07 PM   #14
bigstar
FlashFXP Developer
FlashFXP Administrator
ioFTPD Beta Tester
 
bigstar's Avatar
 
Join Date: Oct 2001
Posts: 8,012
Default

Well it isn't a bug, it's a feature request. I'm wondering if the end result is going to confuse the user. I did a couple scenario tests and I don't really see this feature as being all that pratical.

Maybe you could give me some examples of when and why you would use this.
bigstar is offline  
Old 12-04-2004, 02:36 AM   #15
Witchbender
Junior Member
FlashFXP Registered User
 
Join Date: Mar 2002
Posts: 10
Default

Quote:
Originally posted by bigstar
I'm wondering if the end result is going to confuse the user.
Isn´t it more confusing right now ? Ascii files are shown as different, no matter if they are identical or different. So users can´t rely on the results of the comparison cause they are wrong....... from a certain point of view . I would consider this beeing a bug, even if it is not a coding but a scenario problem.

After all the logical conclusion would be to exclude ascii from "Name & Size" comparison by default instead of adding an additional option.

Quote:
[B]Maybe you could give me some examples of when and why you would use this.[B]
I would use it by default on every comparison to get rid of ascii files shown , because I use it most of the time to see if BIN downloads are complete, therefor i need the Name & Size option.


BTW: an option to exclude skiplisted files would slow it down even more i guess ?
Witchbender is offline  
 

Tags
check, compare, don´t, files, option

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is Off
HTML code is Off

Forum Jump


All times are GMT -5. The time now is 12:11 AM.

Parts of this site powered by vBulletin Mods & Addons from DragonByte Technologies Ltd. (Details)