Go Back   FlashFXP Forums > >

General Discussion Need help? Have a problem? Let us help you. Bug reports and feature requests should be made using the Bug Tracker or Feature Tracker

Closed Thread
 
Thread Tools Rate Thread Display Modes
Old 09-20-2013, 03:58 AM   #1
laager
Junior Member
FlashFXP Beta Tester
 
Join Date: Mar 2007
Posts: 11
Default Can we have the old installer back?

Running 4.4.1. When doing updates, the new installer isn't as simple as the previous installer. One could simply run the update and FlashFXP would automatically restart and be ready for use. This made for a quick and painless update process.

The new installer just isn't as convenient.
laager is offline  
Old 09-20-2013, 04:08 AM   #2
X3
Senior Member
FlashFXP Beta Tester
 
X3's Avatar
 
Join Date: Feb 2006
Location: location, location.
Posts: 324
Default

I have noticed that only the last installer for build 2003 did that, as in refused to kill the runing process, though it did restart ffxp, all previous behaved just the same as old installer use to.

Can you goto about box, details tab and click copy to clipboard and paste that info here.

Cross your fingers this will be looked at.
__________________
Regards
X3 is offline  
Old 09-20-2013, 04:19 AM   #3
laager
Junior Member
FlashFXP Beta Tester
 
Join Date: Mar 2007
Posts: 11
Default

FlashFXP version: 4.4.1 (build 2003)
Operating System: Windows 7 x64 Service Pack 1
Installation type: All User - Common data folder

Program folder [Access: Read / Write]
C:\Program Files (x86)\FlashFXP 4\

Data folder [Access: Read / Write]
C:\ProgramData\FlashFXP\4\

Temp folder [Access: Read / Write]
C:\Users\XXXXXX~1\AppData\Local\Temp\
laager is offline  
Old 09-20-2013, 10:34 AM   #4
bigstar
FlashFXP Developer
FlashFXP Administrator
ioFTPD Beta Tester
 
bigstar's Avatar
 
Join Date: Oct 2001
Posts: 8,012
Default

There is a problem yes, but the problem is not with the new installer.

The problem appears to be with the code that launches the update installer and closes FlashFXP, I have made some changes to address this issue for the next build however since this problem is within FlashFXP you will not be able to see the fix until after you update from the fixed build.

I was not aware of this issue until you reported it, thank you for letting us know.
bigstar is offline  
Old 09-20-2013, 11:23 AM   #5
X3
Senior Member
FlashFXP Beta Tester
 
X3's Avatar
 
Join Date: Feb 2006
Location: location, location.
Posts: 324
Default

Up to build 2000 I never noticed anything its worked flawlessly, closing and updating etc.

But yes, it seems it is failing to close ffxp at least for me.
__________________
Regards

Last edited by X3; 09-20-2013 at 11:28 AM.
X3 is offline  
Old 09-20-2013, 03:15 PM   #6
bigstar
FlashFXP Developer
FlashFXP Administrator
ioFTPD Beta Tester
 
bigstar's Avatar
 
Join Date: Oct 2001
Posts: 8,012
Default

I believe the problem was introduced in build 1999 or 2000.
bigstar is offline  
Old 09-21-2013, 06:38 PM   #7
X3
Senior Member
FlashFXP Beta Tester
 
X3's Avatar
 
Join Date: Feb 2006
Location: location, location.
Posts: 324
Default

Ok build 2004 to 2005 live-update had this problem still.
__________________
Regards
X3 is offline  
Old 09-21-2013, 07:08 PM   #8
bigstar
FlashFXP Developer
FlashFXP Administrator
ioFTPD Beta Tester
 
bigstar's Avatar
 
Join Date: Oct 2001
Posts: 8,012
Default

okay thanks for the heads up, I must of missed something else, I will dig deeper into this issue and see what I can find.
bigstar is offline  
Old 09-21-2013, 07:30 PM   #9
laager
Junior Member
FlashFXP Beta Tester
 
Join Date: Mar 2007
Posts: 11
Default

Previously the last user interaction on an update was this:



ffxp was closed, updated and restarted.

Now, it fails to close ffxp:



..and even after that requires further interaction:



Exactly the same problem on 2004 to 2005.
laager is offline  
Old 09-22-2013, 07:23 AM   #10
bigstar
FlashFXP Developer
FlashFXP Administrator
ioFTPD Beta Tester
 
bigstar's Avatar
 
Join Date: Oct 2001
Posts: 8,012
Default

I have done several tests and I have concluded that there were 3 issues.

* The first issue was fixed in build 2000 where if the shellexecute command that launches the installer with elevation failed with an ERROR_CANCELLED (user said no to the elevation prompt, or didn't have the admin password) it would try to launch the installer without elevation. My intent was to prevent closing FlashFXP if the user canceled.

* The second issue was caused by a mistake in my code where I failed to properly initialize the result value, depending on the specific flow it was possible for the result to remain undefined and this prevented FlashFXP from closing and this was fixed in build 2003.

* The third issue is a rat race, the installer performs a check to detect FlashFXP running before FlashFXP is able to exit.

I added a delay to the check within InstallAware calling the sleep() API, however I forgot that when you call an API in InstallAware all API calls are executed in a secondary thread and as far as I could tell had little or no effect. Since the detection routine is done via a custom DLL that I wrote to handle the detection I have taken the steps within the DLL to perform the detection and if true, wait a second and try again, this should give enough time to prevent the check from triggering during an auto update. (will be added to build 2006)

If any dialog is shown during a silent auto update then any of the remaining dialogs are also shown (installation progress, installation finished) and because they are shown the behavior of the auto update also changes and the option to launch FlashFXP becomes unchecked and the installer doesn't automatically close.

I will release this new build shortly.
bigstar is offline  
Old 09-22-2013, 08:03 AM   #11
X3
Senior Member
FlashFXP Beta Tester
 
X3's Avatar
 
Join Date: Feb 2006
Location: location, location.
Posts: 324
Default

Thanks, its odd it just decided to break, I though these things were do it once and forget, though clearly I have no idea what Im talking about... hehe
__________________
Regards
X3 is offline  
Old 09-22-2013, 12:46 PM   #12
X3
Senior Member
FlashFXP Beta Tester
 
X3's Avatar
 
Join Date: Feb 2006
Location: location, location.
Posts: 324
Default

v4 Build 2005 to 2007 liveupdate was back to normal "smoothness" already.
__________________
Regards
X3 is offline  
Old 09-25-2013, 04:34 AM   #13
X3
Senior Member
FlashFXP Beta Tester
 
X3's Avatar
 
Join Date: Feb 2006
Location: location, location.
Posts: 324
Default

This seems fixed, I have now gone past two updates where everything is smooth as butter. builds 2005 to 2007 and builds 2007 to 2009.

Pending feedback from OP this should be marked as resolved.
__________________
Regards
X3 is offline  
Closed Thread

Tags
automatically, flashfxp, installer, ready, update

Thread Tools
Display Modes Rate This Thread
Rate This Thread:

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -5. The time now is 01:14 PM.

Parts of this site powered by vBulletin Mods & Addons from DragonByte Technologies Ltd. (Details)